Skip to content
Snippets Groups Projects
  • Dennis B's avatar
    6ce0d0b3
    test(prot): add test to exercise RCD1-based keys · 6ce0d0b3
    Dennis B authored and Ethan Reesor's avatar Ethan Reesor committed
    Closes AC-1201
    
    - Cleaned up lite accounts in CLI so that they can be corrected tagged as RCD1 type
    - Streamlined the factoid address handling in cli
    - Corrected bug generating lite account address with RCD hash
    - Added test to add credits, faucet, and move tokens from an RCD-based account
    - Added test to exercise the import of factoid addresses
    - Added restore capability to update the tags and fill lite accounts in the wallet
    - Added the ability to first run the restore function to automatically run the restore accounts on a wallet
    
    ## Review Checklist
    
    **If any item is not complete, the merge request is not ready to be reviewed and must be marked `Draft:`.**
    
    - [x] The merge request title is in the format `<change type>(<change scope>): <short description>`
      - For example, `feat(cli): add QR code generation`
      - For details, see [CONTRIBUTING.md](/CONTRIBUTING.md)
    - [x] The description includes `Closes <jira task ID>` (or rarely `Updates <jira task ID>`)
    - [x] The change is fully validated by tests that are run during CI
      - In most cases this means a test in "validate.sh"
      - In some cases, a Go test may be acceptable
      - Validation is not applicable to things like documentation updates
      - Purely UI/UX changes can be manually validated, such as changes to human-readable output
      - For all other changes, automated validation tests are an absolute requirement unless a maintainer specifically explains why they are not in a comment on this merge request
    - [x] The change is marked with one of the validation labels
      - ~"validation::ci/cd" for changes validated by CI tests
      - ~"validation::manual" for changes validated by hand
      - ~"validation::deferred" for changes validated by a follow up merge request
      - ~"validation::not applicable" for changes where validation is not applicable
    
    ## Merge Checklist
    
    - [ ] CI is passing
    - [ ] Merge conflicts are resolved
    - [ ] All discussions are resolved
    6ce0d0b3
    History
    test(prot): add test to exercise RCD1-based keys
    Dennis B authored and Ethan Reesor's avatar Ethan Reesor committed
    Closes AC-1201
    
    - Cleaned up lite accounts in CLI so that they can be corrected tagged as RCD1 type
    - Streamlined the factoid address handling in cli
    - Corrected bug generating lite account address with RCD hash
    - Added test to add credits, faucet, and move tokens from an RCD-based account
    - Added test to exercise the import of factoid addresses
    - Added restore capability to update the tags and fill lite accounts in the wallet
    - Added the ability to first run the restore function to automatically run the restore accounts on a wallet
    
    ## Review Checklist
    
    **If any item is not complete, the merge request is not ready to be reviewed and must be marked `Draft:`.**
    
    - [x] The merge request title is in the format `<change type>(<change scope>): <short description>`
      - For example, `feat(cli): add QR code generation`
      - For details, see [CONTRIBUTING.md](/CONTRIBUTING.md)
    - [x] The description includes `Closes <jira task ID>` (or rarely `Updates <jira task ID>`)
    - [x] The change is fully validated by tests that are run during CI
      - In most cases this means a test in "validate.sh"
      - In some cases, a Go test may be acceptable
      - Validation is not applicable to things like documentation updates
      - Purely UI/UX changes can be manually validated, such as changes to human-readable output
      - For all other changes, automated validation tests are an absolute requirement unless a maintainer specifically explains why they are not in a comment on this merge request
    - [x] The change is marked with one of the validation labels
      - ~"validation::ci/cd" for changes validated by CI tests
      - ~"validation::manual" for changes validated by hand
      - ~"validation::deferred" for changes validated by a follow up merge request
      - ~"validation::not applicable" for changes where validation is not applicable
    
    ## Merge Checklist
    
    - [ ] CI is passing
    - [ ] Merge conflicts are resolved
    - [ ] All discussions are resolved
Code owners
Assign users and groups as approvers for specific file changes. Learn more.