Skip to content

[#70][#62] Remove VistA Code; Allow CTRL-C

Sam Habiel requested to merge shabiel/YDB-Web-Server:mws70-rm-vista-code into master

VistA Removal (and other small things):

%webapi:

  • Use SRCDIR^%RSEL instead ofRTNDIR^%ZOSV
  • Rename ERR -> err
  • Rename POSTTEST -> posttest, update comments
  • Remove FV, LISTER, F, RPC, rpc2 (all VistA code)
  • Fix Cacheism missed in last commit in FILESYSE

%webreq:

  • Fix Cacheism missing in last commit in job (which is slated for removal anyways)
  • Enable CTRL-C
  • Remove VistA logout
  • Replace $$HTE^%webutils with $ZDATE
  • Remove VistA error trap

%webrsp:

  • Remove the parameters processing (not supported anymore, as that depends on the VistA file)
  • Remove matching against the VistA file 17.6001 for URLs
  • Remove Authentication against VistA
  • Remove RGNET shim

%webtest:

  • Remove ac/vc,dfn for VistA login
  • Fix tgetr text, as the text has changed in the routine and what we validate is no longer there.
  • Enable tputr outside of VistA, as the code in %webapi now can handle it.
  • Remove trpc[1-4], tParams
  • Redo tLog3 to work without VistA
  • Remove tINIT (requires Fileman)
  • Remove resetURLs and anything that relied on it.

%weburl:

  • Move all 17.6001 entries to this file (but no authentication is supported right now)

%webutils:

  • Remove all VistA derived date functions
  • Remove addService, deleteService which added/deleted entries in 17.6001.

Other minor changes:

  • Dockerfile script in ci/run_test.sh edited to allow passing parameters. Documentation in doc/dockerfile-notes.md updated; .gitlab-ci.yml now adjusted for new way of doing this.
  • Dockerfile reorganized so that COPY ./src /mwebserver/r line is the almost the last, as mostly, that's the only code that changes between different runs. This allows for fast regeneration of the Dockerfile.
  • Small README.md change per an earlier review that we wanted to merge without needing to rebase later code.
Edited by Sam Habiel

Merge request reports