Skip to content

[#211] Fix test-auto-upgrade job failure in TAU002 subtest

Ganesh Mahesh requested to merge zylog1O1/YDBOcto:ydbocto211 into master

Issue

  • 533a5090 by mistake was running auto upgrade test queries during bats test execution itself. This was not expected and resulted in the following type of diff in cron job. 
    2023-08-07 02:52:34 : ERROR : [diff TAU002_2.ref output.txt] returned non-zero diff
2023-08-07 02:52:34 : < [ERROR]: ERR_DROP_VIEW_DEPENDS_ON_VIEW: Cannot Drop view "V9" because view "V10" depends on it
2023-08-07 02:52:34 : < [ERROR]: ERR_DROP_VIEW_DEPENDS_ON_VIEW: Cannot Drop view "V9" because view "V11" depends on it
2023-08-07 02:52:34 : > [ERROR]: ERR_CANNOT_DROP_VIEW: Cannot DROP view "V9" as it does not exist
2023-08-07 02:52:34 : > [ERROR]: ERR_UNKNOWN_TABLE: Unknown table: V10
2023-08-07 02:52:34 : > [ERROR]: ERR_CANNOT_DROP_VIEW: Cannot DROP view "V10" as it does not exist
2023-08-07 02:52:34 : > [ERROR]: ERR_CANNOT_DROP_VIEW: Cannot DROP view "V9" as it does not exist
2023-08-07 02:52:34 : > [ERROR]: ERR_UNKNOWN_TABLE: Unknown table: V11
2023-08-07 02:52:34 : > [ERROR]: ERR_CANNOT_DROP_VIEW: Cannot DROP view "V11" as it does not exist
2023-08-07 02:52:34 : > [ERROR]: ERR_UNKNOWN_TABLE: Unknown table: V9
2023-08-07 02:52:34 : > [ERROR]: ERR_CANNOT_DROP_VIEW: Cannot DROP view "V9" as it does not exist

Fix

  • Avoided running the set of queries which are meant to be executed during auto-upgrade by build.sh
  • Removed a copy command usage which was unnecessary as build.sh already does this
  • The test code is now more conformant to the template given at the beginning of test_auto_upgrade.bats.in
  • Updated build.sh to skip TAU002 execution if the older commit is prior to 9fe6a0ad. This avoids this issue in future test-auto-upgrade executions.

Test

  • The existing auto-upgrade cron job and pipeline is sufficient to validate this usecase so no further addition
Edited by Ganesh Mahesh

Merge request reports