Skip to content

Frontend

Martin Rypar requested to merge frontend into master

Even though these changes are quite self-explanatory I have several comments on them.

issue #99 (closed) Docs/guide related commits:
Switching between different html files works now (for example from Gramaticka komponenta to Valence sloves as those are different html files in the background). However, even though the correct html file is opened it does not jump to the correct location (according to clicked link e. g. from Gramaticka komponenta clicking to Valence sloves will open the beginning - Uvod), but stays at the beginning. Not sure why is that so because the hash/link is changed but the view stays the same. Partially good news is that it works as desired on double-click.

issue #50 (closed) Histogram related commits:
To stop computation would be more tricky as it would probably need something like running the computation in separate thread or process which can be killed in case of clicking on some STOP button or field. I assume the reason for the issue is that the computation starts immediately after inputing the attribute (first field) which can be annoying. So I added simple search button instead which will start computing the histogram on clicking it. Now I realize it would be nice to include computation on hitting enter key as well.

issue #48 Scroll up on next page related commits:
A weird behaviour occured here as the scroll up does not work always. I assume the issue might be in asynchronous execution and I will need to get back to it.
Edit:
For replication:
I used only NomVallex.txt and NomVallex-adj.txt files.
It keeps hanging at the bottom when moving for example from 1st page (1-30) to 2nd page (31-60) by clicking the (>) at the bottom. \ Screenshot_from_2021-04-13_10-48-47
I suspect it might be related to the arrangement of these boxes at the Sidebar as it gets stuck the moment the arrangement changes. Happened also for different pages (e.g. 151-180)
Screenshot_from_2021-04-13_10-53-19 Screenshot_from_2021-04-13_10-53-07

Also closes #55 (closed), #107 (closed).

EDIT (12.5.): issue #111 Sidebar - changing width functionality added:
Still does not work perfectly as it needs to click the main (right) panel to reflect the changes on the screen when some parameters changed.\

  1. changing rows per page -> adjust the the tiny grey sidebar border height for dragging will get adjusted only after clicking on the main panel;\
  2. opening sidebar, changing width, closing sidebar and opening sidebar again will result in overlapping with the main page - needs to click the main page again)
Edited by Martin Rypar

Merge request reports