Skip to content

Make RCbenchmark GUI compatible with nw.js 0.71.0.

Marc-Antoine Courteau requested to merge macourteau/RCbenchmarkGUI:master into master

Note that this requires passing the --disable-features=nw2 flag to nw.js. I've changed the Bitrock RCbenchmarkGUI.xml file to include that flag on Windows, but macOS an Linux will likely require a wrapper shell script to launch nw.js with that flag. Without it, some features are not working, such as selecting a directory for the Working Directory (likely caused by https://github.com/nwjs/nw.js/issues/7466).

Other changes:

  • Fixed an issue in the languageSwitcher. jQuery's ajax call was already parsing the JSON and returning an object. The change will only attempt to parse the loaded file if it's a string, but not if it has already been parsed by jQuery;
  • Upgrade to jQuery 3.6.1;
  • Upgrade jQuery-UI to 1.13.2;
  • Remove duplicate entries in the en.json/zh.json files, which made them invalid JSON;
  • Replace the error handler in landing.js with a fail handler, as error is deprecated and no longer available in the more recent builds of jQuery;
  • Removed trailing whitespace in the files I've changed.

Merge request reports