Skip to content

Combination of smaller improvements.

Max-Julian Pogner requested to merge qyanu-pull-requests/vutinfth:develop into master

This pull-request combines the following changes. Reasoning is given for each change.

  • since SOURCE in build-thesis.sh is a user-provided value, best practices of software development dictate to fully quote the variable on every use. Note, that the question whether filenames beginning with a dash '-' or containing other strange characters might still be unaddressed.

  • as an improvement, if SOURCE is acquired through the command line interface instead by editing the script, editing a program by a user can be avoided.

  • build-all.sh: as a personal preference, shell scripts that are intended for normal execution out-of-the-box should have the executable bit set.

  • as seems to me is best practice in software development, logging of shell scripts should be directed towards stderr.

  • using git's .gitignore feature prevents the state of 'dirty work directory' after executing build-all.sh out of the box. Instead, the work directory remains clean if it was clean before.

With best regards,

Max-Julian Pogner

In order to make it explicit, i hereby irrevocably declare that, the contributions are under the MIT license if acquiring a license for them is required by some party. See https://spdx.org/licenses/MIT.html for the full text.

Edited by Max-Julian Pogner

Merge request reports