FIREFOX_98_0_RELEASE does not build (yet): "error: expected identifier"
FYI: When patching a plain vanilla firefox (Tag: FIREFOX_98_0_RELEASE), with the latest unity-menubar.patch, the build process fails at the following stage:
59:57.39 /home/xyz/apps/mozilla/firefox/mozilla-release/firefox-build-dir/dist/include/js/Exception.h:63:3: error: expected identifier
59:57.39 None,
59:57.39 ^
59:57.39 /home/xyz/apps/mozilla/sysroot-x86_64-linux-gnu/usr/include/X11/X.h:115:30: note: expanded from macro 'None'
59:57.39 #define None 0L /* universal null resource or null atom */
The concerning file Exception.h contains here the following:
55 namespace JS {
56
57 // When propagating an exception up the call stack, we store the underlying
58 // reason on the JSContext as one of the following enum values.
59 //
60 // TODO: Track uncatchable exceptions explicitly.
61 enum class ExceptionStatus {
62 // No exception status.
63 None,
64
65 // Used by debugger when forcing an early return from a frame. This uses
66 // exception machinery, but at the right time is turned back into a normal
67 // non-error completion.
68 ForcedReturn,
69
70 // Throwing a (catchable) exception. Certain well-known exceptions are
71 // explicitly tracked for convenience.
72 Throwing,
73 OutOfMemory,
74 OverRecursed,
75 };
I reported this initially at mozilla bugzilla ( See here, including log file: https://bugzilla.mozilla.org/show_bug.cgi?id=1759186 ), but find out it only happened after patching.
Also tag FIREFOX_97_0_1_RELEASE with the unity menubar patch builds without any errors.