Skip to content

Realm: refactor the core module

Wei Wu requested to merge refactor-core into master

This PR will refactor the core module by creating a core folder and other source files just like other modules. Here is a list of files:

  • core_module.cc/h: CoreModuleConfig and CoreModule
  • core_proc.cc/h: LocalCPUProcessor, LocalUtilityProcessor and LocalIOProcessor
  • core_local_channel.cc/h: MemcpyXferDes, MemcpyChannel, MemfillXferDes, MemfillChannel, MemreduceXferDes and MemredeuceChannel
  • core_remote_channel.cc/h: RemoteWriteXferDes and RemoteWriteChannel
  • core_io_channel.cc/h: FileXferDes, FileChannel, DiskXferDes and DiskChannel
  • core_mem.cc/h: FileMemory, DiskMemory and LocalCPUMemory

Other modifications include moving the static functions enumerate_local_cpu_memories and enumerate_remote_cpu_memories from the MemcyChannel into the RuntimImpl.

However, there is an open question: LocalCPUMemory and LocalCPUProcessor are used by both core and numa modules, if we put them into the core module, there could be a problem when we want to support dynamic modules. I do not have a good solution now.

Edited by Wei Wu

Merge request reports