Cap 'workersLate' to max duration.

MERGE REQUEST

MR Guidelines

Overview

This MR is part of a series of small improvements and tweaks to the download code, based upon the recently added traces and investigation benchmarks in Jaeger UI. All MRs will have a baseline benchmark, taken on master, that run a slimmed-down version of the benchmark. It runs 200 files through all sizes, over 1 and 16 threads.

The overdrive code will block on two things:

  • worker updates (new information coming in)
  • all current workers are late

I think it makes sense to cap the latter. This is not a big improvement, but it should act as a fail safe and improve the higher percentile stats. I've seen this improvement in the benchmarks, although not that obvious, I still think the difference is noticeable.

Benchmark Resulsts:

baseline: https://siasky.net/AACXqZ091pTInNRLQU4JjTU_5GiaOaIAvmqIbrZeRD6C2g
improvement: https://siasky.net/AADpkBEwTxqTr3EKrpAgH5G-YbJHnO5VMmhM-rWATFscrA

Checklist

Review and complete the checklist to ensure that the MR is complete before assigned to an approver.

  • All new methods or updated methods have clear docstrings
  • Testing added or updated for new methods
  • Any new packages are added to Makefile and .gitlab-ci.yml
  • API documentation updated for API updates
  • Module README.md updated for changes to workflow
  • Changelog File Created

Issues Closed

N/A

Edited by Peter-Jan Brone

Merge request reports

Loading
Loading