Skip to content

Fix build with recent grpc releases

Dominik Schmidt requested to merge dschmidt1/sila_cpp:current_grpc into master

Hello 👋

I'm assuming you want to keep sila_cpp compatible with older grpc releases for the time being, so this PR is probably not sufficient - but might be useful for other people trying to make it compile for the time being. I have not found a version define, based on which I could easily ifdef the old and the new variant.

Before adding more involved CMake logic to detect the right version, I would like to hear what you think or if this fix is actually correct - at least it works and basically works. The example server is rather crashy when used with the example sila2 browser, no idea if it's because of the new grpc version (or my changes) or if it was like that before already, as I don't have an old grpc available right now.

Let me know what you think!

Best regards Dominik

Merge request reports