Skip to content

Added explicit dependency to abseil by adding find_package(absl)

Dominik Bernhardt requested to merge bico-group/cytena/3rd_party/sila_cpp:find_abseil into master

Description

If gRPC is build according the docs it does not correctly install the abseil include files. I.e. it needs to be build with -DABSL_ENABLE_INSTALL=ON. In this case abeil is correctly installed but it is never included and a subsequent build fails.

What is the current behavior?

A build of sila_cpp is failing with the following errors

CMake Error at cmake/sila_cppConfig.cmake:29 (find_package):
  Found package configuration file:

    /src/install/lib/cmake/grpc/gRPCConfig.cmake

  but it set gRPC_FOUND to FALSE so package "gRPC" is considered to be NOT
  FOUND.  Reason given by package:

  The following imported targets are referenced, but are missing: absl::base
  absl::memory absl::status absl::str_format absl::strings
  absl::synchronization absl::time absl::optional absl::flat_hash_map
  absl::inlined_vector absl::bind_front absl::statusor

Call Stack (most recent call first):
  src/CMakeLists.txt:27 (include)

What is the new/improved behavior?

sila_cpp can be correctly build.

Does this MR introduce any breaking changes?

Other information

Checklist:

  • [ x ] The commit messages follow our guidelines
  • [ x ] If necessary, tests have been added
  • [ n/a ] Docs have been added / updated
  • CHANGELOG.md has been updated in the Added/Changed section

Merge request reports