Skip to content

Use TARGET_PROTOC_GENERATE_CPP where applicable

Dominik Schmidt requested to merge dschmidt1/sila_cpp:cmake_fix into master

Description

This makes use of TARGET_PROTOC_GENERATE_CPP where currently applicable.

In src/CMakeLists.txt it currently cannot be used for multiple reasons:

  • there are no implementation files
  • the target is exported and include dirs point into the build dir, they may only be added to the BUILD_INTERFACE
  • possibly more

I don't have time to deal with that, but this current change was a low hanging fruit :)

What is the current behavior?

What is the new/improved behavior?

Does this MR introduce any breaking changes?

Other information

Checklist:

  • The commit messages follow our guidelines
  • If necessary, tests have been added
  • Docs have been added / updated
  • CHANGELOG.md has been updated in the Added/Changed section

Merge request reports