Skip to content

Don't extract title if request is unsuccessful

GermainZ requested to merge GermainZ/golbot-rust:patch-1 into master

GOLBot currently announces titles of webpages even if the request fails (e.g. 404).
This does not seem to be very useful, and is a bit spammy.

Before:

<SysGhost> https://www.youtube.com/watch?v=qAhK9TMPEtI&t=165s
<GOLBot> URL: Error - Invidious
<Solitary> https://antidepressantsortolkien.now.sh/
<GOLBot> URL: Antidepressants or Tolkien
<GermainZ> https://google.com/asdnoisad
<GOLBot> URL: Error 404 (Not Found)!!1

After:

<Solitary> https://antidepressantsortolkien.now.sh/
<GOLBot> URL: Antidepressants or Tolkien

Alternatively, if you think this behavior should be kept, I'd suggest making it clearer it's an error as it can lead to confusion otherwise:

<TwistedFate> https://www.youtube.com/watch?v=Eoo8EyNH3GM
<GOLBot> URL: Error - Invidious
<xtort-> wtf kinda error is that?
<SysGhost> Could it be that the bot is based in Germany, and the video in question is banned/not allowed in that region? (Wolfenstein games there are something of concern, right?)
<Solitary> most likely the service that provides the parsed titles pooped out
<SysGhost> Invidious: incur resentment or anger (just for the records)
<Solitary> according to online service the video is unrestricted
<SysGhost> That's true, but regional rules might override that.
<Solitary> you mean ISP blocking it?
<SysGhost> could be.
<Solitary> hope thats not the case
<Solitary> thats pretty shitty
…

Merge request reports