Can't package version 1.4.11 for openSUSE Leap

While packaging for the latest Tumbleweed version, packaging for all stable Leap version fails here. Any idea?

[  120s] [ 20%] Linking C shared library remmina-plugin-spice.so
[  120s] cd /home/abuild/rpmbuild/BUILD/Remmina-v1.4.11/build/plugins/spice && /usr/bin/cmake -E cmake_link_script CMakeFiles/remmina-plugin-spice.dir/link.txt --verbose=1
[  120s] /usr/bin/cc -fPIC -fmessage-length=0 -grecord-gcc-switches -O2 -Wall -D_FORTIFY_SOURCE=2 -fstack-protector-strong -funwind-tables -fasynchronous-unwind-tables -fstack-clash-protection -g -fPIE -pie -DNDEBUG -fPIC -Wall -g -O2 -g -DNDEBUG -Wl,--as-needed -Wl,--no-undefined -Wl,-z,now -shared  -o remmina-plugin-spice.so CMakeFiles/remmina-plugin-spice.dir/spice_plugin.c.o CMakeFiles/remmina-plugin-spice.dir/spice_plugin_file_transfer.c.o CMakeFiles/remmina-plugin-spice.dir/spice_plugin_usb.c.o -lgtk-3 -lgdk-3 -lglib-2.0 -lgio-2.0 -lgobject-2.0 -lgmodule-2.0 -lgthread-2.0 -lpango-1.0 -lcairo -lgdk_pixbuf-2.0 -latk-1.0 -lpthread -lspice-client-gtk-3.0 -lgtk-3 -lgdk-3 -lpangocairo-1.0 -lpango-1.0 -latk-1.0 -lcairo-gobject -lcairo -lgdk_pixbuf-2.0 -lgio-2.0 -lgobject-2.0 -lglib-2.0 -lspice-client-glib-2.0 
[  120s] /usr/lib64/gcc/x86_64-suse-linux/7/../../../../x86_64-suse-linux/bin/ld: CMakeFiles/remmina-plugin-spice.dir/spice_plugin.c.o: in function `remmina_plugin_spice_display_ready_cb':
[  120s] /home/abuild/rpmbuild/BUILD/Remmina-v1.4.11/plugins/spice/spice_plugin.c:382: undefined reference to `spice_display_channel_change_preferred_video_codec_types'
[  120s] collect2: error: ld returned 1 exit status
[  120s] make[2]: *** [plugins/spice/CMakeFiles/remmina-plugin-spice.dir/build.make:161: plugins/spice/remmina-plugin-spice.so] Error 1
[  120s] make[2]: Leaving directory '/home/abuild/rpmbuild/BUILD/Remmina-v1.4.11/build'
[  120s] make[1]: *** [CMakeFiles/Makefile2:557: plugins/spice/CMakeFiles/remmina-plugin-spice.dir/all] Error 2
[  120s] make[1]: *** Waiting for unfinished jobs....

changed the description

That symbol is in spice-client

https://lazka.github.io/pgi-docs/SpiceClientGLib-2.0/mapping.html

There must be some change in the spice related libraries. Here is the difference:

Laep 15.2 (not ok)	Tumbleweed (ok)
spice-protocol-devel-0.14.0	spice-protocol-devel-0.14.3
libspice-client-glib-helper-0.37	libspice-client-glib-helper-0.39
libspice-client-glib-2_0-8-0.37	libspice-client-glib-2_0-8-0.39
typelib-1_0-SpiceClientGlib-2_0-0.37	typelib-1_0-SpiceClientGlib-2_0-0.39
libspice-client-gtk-3_0-5-0.37	libspice-client-gtk-3_0-5-0.39
typelib-1_0-SpiceClientGtk-3_0-0.37	typelib-1_0-SpiceClientGtk-3_0-0.39
spice-gtk-devel-0.37	spice-gtk-devel-0.39

@hadogenes do you mind adding some #ifdef to avoid that symbol if spice-client is less then 0.39?

Please let me know about it! I'll test the patches ASAP.

mentioned in merge request !2194 (merged)

There is spice_display_channel_change_preferred_video_codec_type function availablebfrom 0.35 which can be used (now it is deprecated) I'll push this later

Thanks, much appreciated.

Maybe keeping both with an ifdef to match the installed spice version.

Take your time.

@jweberhofer we will drop your MR, bit it'll be useful as reference. Thanks!

Do you think I have to check versions before 0.34 (about 3 years ago)? - disable codec selection, if earlier

0.35 as you have done should be enough.

We'll see if anybody else will have issues

Thanks again

mentioned in merge request !2195 (merged)

closed with merge request !2195 (merged)

mentioned in commit 85cc122b

mentioned in commit f10ffaea

mentioned in commit c5a63bdf

mentioned in merge request !2213 (merged)

mentioned in commit 7c56fd5a