Cannot compile CP in version 6.3 if __OLDXML is defined
In the released version 6.3, if -D__OLDXML
is used, target cp
fails to compile with the following error:
>> 3565 cp_restart_new.f90(2058): error #6404: This name does not have a type, and must have an explicit type. [TMP_DIR]
3566 WRITE(dirname,'(A,A,"_",I2,A)') TRIM(tmp_dir), TRIM(prefix), ndw,postfix
3567 -----------------------------------------^
>> 3568 cp_restart_new.f90(2058): error #6362: The data types of the argument(s) are invalid. [TRIM]
3569 WRITE(dirname,'(A,A,"_",I2,A)') TRIM(tmp_dir), TRIM(prefix), ndw,postfix
3570 -----------------------------------------^
>> 3571 cp_restart_new.f90(2058): error #6404: This name does not have a type, and must have an explicit type. [PREFIX]
3572 WRITE(dirname,'(A,A,"_",I2,A)') TRIM(tmp_dir), TRIM(prefix), ndw,postfix
3573 --------------------------------------------------------^
>> 3574 cp_restart_new.f90(2058): error #6362: The data types of the argument(s) are invalid. [TRIM]
3575 WRITE(dirname,'(A,A,"_",I2,A)') TRIM(tmp_dir), TRIM(prefix), ndw,postfix
3576 --------------------------------------------------------^
>> 3577 cp_restart_new.f90(2058): error #6404: This name does not have a type, and must have an explicit type. [POSTFIX]
3578 WRITE(dirname,'(A,A,"_",I2,A)') TRIM(tmp_dir), TRIM(prefix), ndw,postfix
3579 ---------------------------------------------------------------------^
>> 3580 cp_restart_new.f90(2060): error #6404: This name does not have a type, and must have an explicit type. [IUNPUN]
3581 IF ( ionode ) OPEN( unit=iunpun, file =TRIM(filename), &
3582 -----------------------------^
>> 3583 cp_restart_new.f90(2110): error #6362: The data types of the argument(s) are invalid. [TRIM]
3584 WRITE(dirname,'(A,A,"_",I2,A)') TRIM(tmp_dir), TRIM(prefix), ndr,postfix
3585 -----------------------------------------^
>> 3586 cp_restart_new.f90(2110): error #6362: The data types of the argument(s) are invalid. [TRIM]
3587 WRITE(dirname,'(A,A,"_",I2,A)') TRIM(tmp_dir), TRIM(prefix), ndr,postfix
3588 --------------------------------------------------------^
3589 compilation aborted for cp_restart_new.f90 (code 1)
>> 3590 ../../make.inc:16: set di istruzioni per l'obiettivo "cp_restart_new.o" non riuscito
>> 3591 make[2]: *** [cp_restart_new.o] Errore 1
3592 make[2]: uscita dalla directory "/tmp/mborelli/spack-stage/spack-stage-RoP6oo/q-e-qe-6.3/CPV/src"
3593 Makefile:7: set di istruzioni per l'obiettivo "all" non riuscito
>> 3594 make[1]: *** [all] Errore 1
3595 make[1]: uscita dalla directory "/tmp/mborelli/spack-stage/spack-stage-RoP6oo/q-e-qe-6.3/CPV"
3596 Makefile:73: set di istruzioni per l'obiettivo "cp" non riuscito
>> 3597 make: *** [cp] Errore 1
Basically, the variables prefix
, postfix
, iunpun
, tmp_dir
are undeclared in CPV/src/cp_restart_new.f90
, because their USE statement is wrapped in a block:
#if !defined(__OLDXML)
...
#endif
This issue is not present any more in the latest "develop", because support for __OLDXML has been removed. However, I was wondering if it would be possible to release a version 6.3.1, forked from 6.3, which contains fixes for both this issue and issue #50 (closed).
In either case, I think these two issues should be documented:
- in
Doc/release-notes
-- I have opened a merge request for this (!144 (merged)); - in this wiki page, which I'm not allowed to edit.
Thank you.