Prettier
This adds prettier as a separate command in the package.json as well as part of the es-lint step
However, there is also a problem in the HTML markup detected by prettier
imports/ui/pages/venue-details/template.html [error] imports/ui/pages/venue-details/template.html: SyntaxError: Unexpected closing tag "p". It may happen when the tag has already been closed by another tag. For more info see https://www.w3.org/TR/html5/syntax.html#closing-elements-that-have-implied-end-tags (33:10) [error] 31 | [error] 32 | [error] > 33 |
[error] | ^^^^ [error] 34 | {{/if}} [error] 35 | {{#if this.venue.address}} [error] 36 |imports/ui/pages/venues-map/index.app-test.ts 34ms
This is because you cannot put a ul
element within a p
element. A list can only go inside a div
element. You can add the change to this MR. @ToastHawaii
What does this MR do?
Related issues
Screenshots
Author's checklist
-
Follow the Style Guide. -
Issue being solved is linked -
Screenshots are added -
A test that checks the issue is resolved (If you don't know how to do that, create the MR as WIP)
Review checklist
All reviewers can help ensure accuracy, clarity, completeness, and adherence to the Style Guide.
1. Primary Reviewer
-
Review by a code reviewer or other selected colleague to confirm accuracy, clarity, and completeness. This can be skipped for minor fixes without substantive content changes.