Skip to content

338 ValueTupleCannotLoad: Fix

Rolf Madsen requested to merge 338-ValueTupleCannotLoad into master

Fixed issue by not using value tuple in the assembly resolver.

Added a log message whenever a dll is loaded in debug mode only and verified the fix by inspecting the log.

Closes #338 (closed)

Verification:

00:00:00.066 : Session       : Debug       : Microsoft Windows 10.0.17763 X64                                                                                              
00:00:00.066 : Session       : Debug       : .NET Framework 4.7.3640.0                                                                                                     
00:00:00.075 : Resolver      : Debug       : Found 249/249 assembly files. [10.8 ms]                                                                                       
00:00:00.077 : Session       : Debug       : OpenTAP Engine 9.4.0-Development X64                                                                                          
00:00:00.112 : PluginManager : Debug       : Loaded Assembly System.Reflection.Metadata, Version=1.4.3.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a                 
00:00:00.113 : PluginManager : Debug       : Loaded Assembly netstandard, Version=2.0.0.0, Culture=neutral, PublicKeyToken=cc7b13ffcd2ddd51                                
00:00:00.118 : PluginManager : Debug       : Loaded Assembly System.Collections.Immutable, Version=1.2.3.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a               
!!! ------------- Assembly Resolver is loaded ------------
00:00:00.167 : Searcher      : Debug       : Ordered 245 assemblies according to references. [89.4 ms]                                                                     
00:00:00.260 : PluginManager : Debug       : Loaded Assembly Microsoft.CSharp, Version=4.0.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a                           
00:00:00.262 : PluginManager : Debug       : Loaded OpenTap. [234 us]                                                                                                      
00:00:00.271 : PluginManager : Debug       : Loaded Assembly OpenTap.UnitTests, Version=0.0.0.0, Culture=neutral, PublicKeyToken=null                                      
00:00:00.271 : PluginManager : Debug       : Loaded OpenTap.UnitTests. [9.59 ms]                                                                                           
00:00:00.278 : PluginManager : Debug       : Loaded Assembly OpenTap.Plugins.BasicSteps, Version=9.4.0.0, Culture=neutral, PublicKeyToken=null                             
00:00:00.278 : PluginManager : Debug       : Loaded OpenTap.Plugins.BasicSteps. [1.65 ms]                         
!!! ------------- Now Value TUple is Loaded ------------                                                         
00:00:00.303 : PluginManager : Debug       : Loaded Assembly System.ValueTuple, Version=4.0.0.0, Culture=neutral, PublicKeyToken=cc7b13ffcd2ddd51                          
00:00:00.354 : Settings      : Debug       : No settings file exists for EngineSettings. A new instance with default values has been created. [5.33 ms]                    
00:00:00.368 : Session       : Debug       : Session log loaded as 'C:\Users\romadsen\projects\opentap\bin\Debug\SessionLogs\SessionLog 2020-08-27 10-55-09.txt'. [3.72 ms]

Merge request reports