Merge branch '201-document-dotnet-runtime-dependency' into 'master'

Add warning to install script, and document dotnet runtime dependency

Closes #199 and #201

See merge request !411

LinuxInstall/INSTALL.sh

@@ -7,12 +7,29 @@
 # This Source Code Form is subject to the terms of the Mozilla Public
 # License, v. 2.0. If a copy of the MPL was not distributed with this
 # file, You can obtain one at http://mozilla.org/MPL/2.0/.
+
+NETCORE_INSTALLED="$(dotnet --list-runtimes | grep -E "NETCore\.App.2")"
+if [ -z "$NETCORE_INSTALLED" ]; then
+    printf 'OpenTAP depends on dotnet runtime 2.1 which is not installed.
+Please see https://docs.microsoft.com/en-us/dotnet/core/install/runtime for installation instructions
+'
+fi
+
 DEST_DIR=$HOME/.tap
 BIN_DIR=$HOME/bin
 
 echo "TAP will be installed in $DEST_DIR, and shortcuts in $BIN_DIR"
+
+if [ -e "$DEST_DIR" ] && [ -n "$(ls -A "$DEST_DIR")" ]; then
+    echo "Warning: $DEST_DIR is not empty. This script is intended for clean installs."
+    echo "If you are upgrading OpenTAP, the preferred method is 'tap package install OpenTAP'."
+    echo "Upgrading with this script may lead to a broken install."
+fi
+
 while true; do
-    read -p "Do you wish to install?" yn
+    read -p 'Do you wish to install OpenTAP?
+' yn
+
     case $yn in
         [Yy]* ) break;;
         [Nn]* ) exit;;

doc/README.md

@@ -28,14 +28,18 @@ tap package install "Developer's System CE" -y
 <!--When installing on Linux there are a few options:-->
 #### 1. Install dependencies
 On Linux, OpenTAP has a few dependencies that must be manually installed, namely
-libc6, libunwind, unzip, and git. On Debian derivatives, these can be installed
+libc6, libunwind, unzip, git, and curl. On Debian derivatives, these can be installed
 by running the following command:
 
-`apt-get install libc6-dev, libunwind8, unzip, git`
+`apt-get install libc6-dev libunwind8 unzip git curl`
 
 Note that the packages may have different names on other distributions. OpenTAP
 should still work if you install the equivalent packages for your distribution.
 
+In addition to these packages, OpenTAP depends on dotnet core runtime version 2.1. Version 3.0 and greater are not
+supported. The installation procedure depends on your distribution. Please see [the official documentation from
+Microsoft ](https://docs.microsoft.com/en-us/dotnet/core/install/runtime) for further instructions.
+
 #### 2. Install OpenTAP
 Download the OpenTAP distribution (`.tar`<!--, `.dep` or `.rpm`-->) from our homepage [here](https://www.opentap.io/download.html).