Draft: issue 6518 move nif reading implementation
resolves #6518 (closed)
This is a first go at this. I moved all the implementation to the cpp files except for functions that were "trivial" (usually 3 lines or less). I can do them all if desired.
I also did some crude before and after performance testing just to see if the changes had any obvious effect, and it seems to me that there's no noticable performance impact. The test was really crude, though. I just loaded a saved game and spent 20 seconds slowly looking around outside in Seyda Neen, and then inside the Census office there.
BEFORE CHANGES
eris@galadriel:~/dev/openmw/openmw/scripts$ python3 osg_stats.py --stats="Frame rate|Nif" --regexp_match /tmp/stats-master
| source | key | number | min | max | mean | median | stdev | q95 |
|---|---|---|---|---|---|---|---|---|
| /tmp/stats-master | Frame rate | 10418 | 0.0 | 1362.4 | 247.52272451430215 | 299.76 | 91.29674803888372 | 304.507 |
| /tmp/stats-master | Nif | 10418 | 0 | 970 | 0 | 0.0 | 13.416407864998739 | 0.0 |
AFTER CHANGES
eris@galadriel:~/dev/openmw/openmw/scripts$ python3 osg_stats.py --stats="Frame rate|Nif" --regexp_match /tmp/stats-new
| source | key | number | min | max | mean | median | stdev | q95 |
|---|---|---|---|---|---|---|---|---|
| /tmp/stats-new | Frame rate | 10222 | 0.0 | 5586.59 | 255.93255559773038 | 299.85 | 100.98228059258301 | 305.344 |
| /tmp/stats-new | Nif | 10222 | 0 | 970 | 0 | 0.0 | 13.564659966250536 | 0.0 |
edit by psi29a, changed ! to # for issue above.