Skip to content
GitLab
    • GitLab: the DevOps platform
    • Explore GitLab
    • Install GitLab
    • How GitLab compares
    • Get started
    • GitLab docs
    • GitLab Learn
  • Pricing
  • Talk to an expert
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
    • Switch to GitLab Next
    Projects Groups Snippets
  • Sign up now
  • Login
  • Sign in / Register
  • openmw openmw
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Issues 845
    • Issues 845
    • List
    • Boards
    • Service Desk
    • Milestones
    • Iterations
  • Merge requests 40
    • Merge requests 40
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
    • Test Cases
  • Deployments
    • Deployments
    • Releases
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Code review
    • Insights
    • Issue
    • Repository
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • OpenMWOpenMW
  • openmwopenmw
  • Merge requests
  • !1316

Overhaul raindrop water ripple effect

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged wareya requested to merge wareya/openmw:master into master Oct 23, 2021
  • Overview 84
  • Commits 13
  • Pipelines 10
  • Changes 7
  • Replace raindrop ripple math with math that more clearly generates actual ripples.
  • Make raindrop ripple random placement change over time instead of only over different positions
  • Make the forced specularity/whiteness/lightness of water ripples use the absolute height of the ripple instead of the height itself. Doing max(0, ...) would technically be better but the difference isn't significant and abs() is shorter. Willing to change this to max(0, ...) if desired.

This looks slightly weird with refraction water (some ripples look "brown"), but only because refraction water itself handles estimated sunlight scattering improperly (the "brown"ness is only because those parts the ripples aren't green like their surroundings).

Willing to re-rewrite the math if the new math is too long/verbose to be wanted.

Closes #6360 (closed).

Edited Oct 23, 2021 by wareya
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: master