Skip to content

Refactor: use Singleton pattern for accessing Settings

Thore Göbel requested to merge thgoebel/findmydevice:settings-singleton into master

Use the Singleton pattern for accessing Settings.

This avoid the notorious race conditions that occur when every piece of code opens the settings file on its own (e.g. the networking code running in a different thread).

Also remove the set vs setNow. I don't see high value in storing settings delayed. Just store them immediately.

Merge request reports