Skip to content

fix: Empty Skyfile Upload

Peter-Jan Brone requested to merge fix-empty-skyfile-upload into master

MERGE REQUEST

MR Guidelines

Overview

This MR removes the check where we assert the Length property in the Skyfile's metadata is not zero. This check was added to ensure length was being set, but did not take into account we actually allow the uploading of empty parts. I have changed it to error out when the length is zero and subfiles is either nil, or if subfiles contain a part with length greater than zero. This should then only occur when the length property is incorrectly set on the metadata.

Example for Visual Changes

N/A

Checklist

Review and complete the checklist to ensure that the MR is complete before assigned to an approver.

  • All new methods or updated methods have clear docstrings
  • Testing added or updated for new methods
  • Any new packages are added to Makefile and .gitlab-ci.yml
  • API documentation updated for API updates
  • Module README.md updated for changes to workflow
  • Issue added to Sia-UI repo for new supporting features
  • Changelog File Created

Issues Closed

N/A

Merge request reports