Skip to content

[MINOR] Spending Metrics F/U 3/3

Peter-Jan Brone requested to merge update-financial-metrics-fu-3 into master

MERGE REQUEST

MR Guidelines

Overview

This MR removes the RPC field from the payment details. Chris rightfully suggested to remove this as it is redundant. If we provide a non zero account id as the refill account the host will simply error out. Having the sanity check is pretty useless, especially how it was constructed. It also adds a test that verifies whether the spending metrics get updated using the worker tester. Theh plan is to extend upon this test when adding EA tracking.

Example for Visual Changes

N/A

Checklist

Review and complete the checklist to ensure that the MR is complete before assigned to an approver.

  • All new methods or updated methods have clear docstrings
  • Testing added or updated for new methods
  • Any new packages are added to Makefile and .gitlab-ci.yml
  • API documentation updated for API updates
  • Module README.md updated for changes to workflow
  • Issue added to Sia-UI repo for new supporting features
  • Changelog File Created

Issues Closed

Closes #4512 (closed)

Merge request reports