Skip to content

[MINOR] TestSkynetDownloadByRoot NDF fix/harden

Peter-Jan Brone requested to merge fix-no-workers-hardening into master

MERGE REQUEST

MR Guidelines

Overview

This MR is an attempt at hardening/fixing the NDF that occurs in TestSkynetDownloadByRoot. I can't reproduce that locally, so that is annoying but I think the problem might be that not enough workers are in the worker heap. This can be due to a potential cooldown, or simply the worker not being ready yet to handle RHP3 jobs. I have added maxWaitEnoughWorkers - which is the maximum duration we will allow the download code to wait until enough workers are in the worker heap at least.

The fix is harmless imo, and seeing as it might fix the NDF I thought to propose it as a solution. I've also added logging, all be it minor, to give us more insights into what is happening when it does occur again.

Example for Visual Changes

N/A

Checklist

Review and complete the checklist to ensure that the MR is complete before assigned to an approver.

  • All new methods or updated methods have clear docstrings
  • Testing added or updated for new methods
  • Any new packages are added to Makefile and .gitlab-ci.yml
  • API documentation updated for API updates
  • Module README.md updated for changes to workflow
  • Issue added to Sia-UI repo for new supporting features
  • Changelog File Created

Issues Closed

N/A

Merge request reports