Skip to content

MemoryManager RequestWithContext

Peter-Jan Brone requested to merge request-memory-with-context into master

MERGE REQUEST

MR Guidelines

Overview

This MR contains a small extension to the memory manager, required for the new download code. It adds a method RequestWithContext to the MemoryManager allowing to pass a context that potentially cancels out before the memory is available. This way we can properly adhere to user-imposed timeouts when downloading skyfiles. Currently we ignore this in some locations and simply start the timeout after the blocking call to the memory manager.

Note:

I've chosen RequestWithContext because it allows keeping all current usages of the memory manager the same... I think requiring a context in all those locations is a bit of an overkill and needless change. Especially since we are about to overhaul the memory manager system anyway soon.

Example for Visual Changes

N/A

Checklist

Review and complete the checklist to ensure that the MR is complete before assigned to an approver.

  • All new methods or updated methods have clear docstrings
  • Testing added or updated for new methods
  • Any new packages are added to Makefile and .gitlab-ci.yml
  • API documentation updated for API updates
  • Module README.md updated for changes to workflow
  • Issue added to Sia-UI repo for new supporting features
  • Changelog File Created

Issues Closed

N/A

Edited by Peter-Jan Brone

Merge request reports