Skip to content

Job Metadata

Peter-Jan Brone requested to merge job-metadata into master

MERGE REQUEST

MR Guidelines

Overview

This MR adds metadata to jobRead. The way jobRead structs are created were perfectly fine, until implement something that receives multiple jobs on the response channel. Reason being is that you've lost context on what response belongs to what sector root... The new download code runs into this problem.

The solution here is not ideal. I've discussed it with Chris and there's a couple of options but the best option would be to refactor the read jobs a bit on the renter side. This is not a priority at the moment, so tacking on this information as metadata on the jobRead is fine for now.

Example for Visual Changes

N/A

Checklist

Review and complete the checklist to ensure that the MR is complete before assigned to an approver.

  • All new methods or updated methods have clear docstrings
  • Testing added or updated for new methods
  • Any new packages are added to Makefile and .gitlab-ci.yml
  • API documentation updated for API updates
  • Module README.md updated for changes to workflow
  • Issue added to Sia-UI repo for new supporting features
  • Changelog File Created

Issues Closed

N/A

Merge request reports