ETag response header
MERGE REQUEST
Overview
Jan Vorberger, a community member, reported an issue in our server's response to the If-Range header. Upon investigation, I realized we were not returning the ETag between quotes, as suggested in https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/ETag
"<etag_value>" Entity tag uniquely representing the requested resource. They are a string of ASCII characters placed between double quotes, like "675af34563dc-tr34".
Aside from that I have removed all code that handled the ETag related headers, instead we now let serveContent take care of everything for us. I have deployed it to siasky.dev, and thanks to Jan's excellent issue description was able to verify this ensures we return only the range if the If-Range header is given.
Example for Visual Changes
N/A
Checklist
Review and complete the checklist to ensure that the MR is complete before assigned to an approver.
-
All new methods or updated methods have clear docstrings -
Testing added or updated for new methods -
Any new packages are added to Makefile and .gitlab-ci.yml -
API documentation updated for API updates -
Module README.md updated for changes to workflow -
Issue added to Sia-UI repo for new supporting features -
Changelog File Created
Issues Closed
Closes #4390 (closed)