SkyfileUploadReader

MERGE REQUEST

NOTE

DO NOT MERGE BEFORE v151 IS OUT

MR Guidelines

Overview

This MR introduces a new interface called SkyfileUploadReader. It wraps a reader and allows retrieving the SkyfileMetadata after all data has been fully read. This is useful because it allows us to skip ParseForm in the multipart upload.

This means that:

• we do not have to read everything into memory before we can start uploading
• we no longer write to temp files if a part is larger than 32MiB
• we will potentially have started uploading chunks while the rest of the multipart form is still being processed

There are some downsides to it as well:

• we do not catch illegal part metadata before uploading has initiated

Example for Visual Changes

N/A

Checklist

Review and complete the checklist to ensure that the MR is complete before assigned to an approver.

• All new methods or updated methods have clear docstrings
• Testing added or updated for new methods
• Any new packages are added to Makefile and .gitlab-ci.yml
• API documentation updated for API updates
• Module README.md updated for changes to workflow
• Issue added to Sia-UI repo for new supporting features
• Changelog File Created

Issues Closed

N/A