Skip to content

Draft: Fix Master

Peter-Jan Brone requested to merge pj/fix-master into master

MERGE REQUEST

MR Guidelines

Overview

This MR fixes the failing pipelines by using the appropriate resolver. It does this by actually calling Resolver() on the dependencies opposed to LookupIP directly (which uses the net package to resolve the host to an IP). What bugs me immensely is that I have not found why this is broken...

If locally, I go back to v142, it fails. It must be due to a recent change, I believe the host dependencies were injected and now are not injected, however for the life of me I can't figure out where... I only submitted this MR to see if the entire suite passes with this fix.

Example for Visual Changes

N/A

Checklist

Review and complete the checklist to ensure that the MR is complete before assigned to an approver.

  • All new methods or updated methods have clear docstrings
  • Testing added or updated for new methods
  • Any new packages are added to Makefile and .gitlab-ci.yml
  • API documentation updated for API updates
  • Module README.md updated for changes to workflow
  • Issue added to Sia-UI repo for new supporting features
  • Changelog File Created

Issues Closed

N/A

Merge request reports