Skip to content

AOP File Handle Bug

Matthew Sevey requested to merge sevey/fix-aop-file-handle into master

MERGE REQUEST

MR Guidelines

Overview

There was a missed file handle closure in the append only persist object from the persist package. This wasn't an issue until we encountered our first persist compat code as prior to needing compat code the subsystem using the AOP would shutdown due to being unable to start up. The compat code tries to open the persistence again and highlighted this miss on windows.

Bug verified on windows runner:

Bug fix verified on windows runner:

Example for Visual Changes

Checklist

Review and complete the checklist to ensure that the MR is complete before assigned to an approver.

  • All new methods or updated methods have clear docstrings
  • Testing added or updated for new methods
  • Any new packages are added to Makefile and .gitlab-ci.yml
  • API documentation updated for API updates
  • Module README.md updated for changes to workflow
  • Issue added to Sia-UI repo for new supporting features
  • Changelog File Created

Issues Closed

Edited by Matthew Sevey

Merge request reports