Skip to content

Fix panic in the wal fir siadir and siafile

Matthew Sevey requested to merge sevey/wal-delete-update-panic into master

MERGE REQUEST

MR Guidelines

Overview

The wal for the siadir and the siafile will try and apply any delete updates first and then truncate the updates to avoid applying unnecessary updates.

Due to an improper use of break there was an edge case were if the last update in a set of updates was the delete update an out of bounds panic would be trigger.

This MR fixes the panic and adds regression testing for both siafile and siadir.

Example for Visual Changes

Checklist

Review and complete the checklist to ensure that the MR is complete before assigned to an approver.

  • All new methods or updated methods have clear docstrings
  • Testing added or updated for new methods
  • Any new packages are added to Makefile and .gitlab-ci.yml
  • API documentation updated for API updates
  • Module README.md updated for changes to workflow
  • Issue added to Sia-UI repo for new supporting features
  • Changelog File Created

Issues Closed

Merge request reports