Skip to content

Check contract size before downloading snapshot table

Christopher Schinnerl requested to merge chris/snapshot-table-oob-check into master

MERGE REQUEST

MR Guidelines

Overview

This MR fixes at least 1 NDF (TestSkyKey/LargeFilePrivateID) and potentially many more. The reason being that workers on cooldown won't accept jobs and even drop existing work. The snapshot synchronisation thread will try to download snapshot tables and if a host doesn't have a snapshot table yet, the download will fail and it will put the worker on a cooldown. To prevent that, I added an early check that guarantees we don't try to download the snapshot table unless the contract has a positive size to indicate that a snapshot table could exist.

Checklist

Review and complete the checklist to ensure that the MR is complete before assigned to an approver.

  • All new methods or updated methods have clear docstrings
  • Testing added or updated for new methods
  • Any new packages are added to Makefile and .gitlab-ci.yml
  • API documentation updated for API updates
  • Module README.md updated for changes to workflow
  • Issue added to Sia-UI repo for new supporting features
  • Changelog File Created

Merge request reports