Skip to content

Default path: disabling the default path

Ivaylo Novakov requested to merge ivo/nodefaultpath into master

MERGE REQUEST

MR Guidelines

Overview

This MR introduces the NoDefaultPath parameter which indicates that the default path functionality is disabled for this skyfile.

As part of this change I've added a table test that aims to cover all situations where this option might be used. This test is called testSkynetDefaultPath_TableTest and it might render testSkynetDefaultPath redundant. I am not sure if that's the case, so I've kept the older test as well.

In the test there are a couple of TODOs - those are not forgotten, these indicate points of uncertainty. We need to explicitly decide what to do in those cases and I will update the MR.

Example for Visual Changes

Checklist

Review and complete the checklist to ensure that the MR is complete before assigned to an approver.

  • All new methods or updated methods have clear docstrings
  • Testing added or updated for new methods
  • Any new packages are added to Makefile and .gitlab-ci.yml
  • API documentation updated for API updates
  • Module README.md updated for changes to workflow
  • Issue added to Sia-UI repo for new supporting features
  • Changelog File Created

Issues Closed

Merge request reports