Skip to content

Validate Skynet filenames when uploading

Marcin S. requested to merge skynet-filename-validation into master

MERGE REQUEST

MR Guidelines

Overview

Add validation for Skynet filenames, both for single file uploads and multipart (directory) uploads. See issue for more background.

This is backwards-compatible as any filenames previously uploaded will still be accessible if they were previously. Filenames uploaded containing ../, // or starting with / were previously inaccessible.

Example for Visual Changes

Checklist

Review and complete the checklist to ensure that the MR is complete before assigned to an approver.

  • All new methods or updated methods have clear docstrings
  • Testing added or updated for new methods
  • Any new packages are added to Makefile and .gitlab-ci.yml
  • API documentation updated for API updates
  • Module README.md updated for changes to workflow
  • Issue added to Sia-UI repo for new supporting features
  • Changelog File Created

Issues Closed

Closes #4260 (closed)

Edited by Marcin S.

Merge request reports