Skip to content

Resolve "Panic in TestRemoteBackup"

Matthew Sevey requested to merge 4265-panic-in-testremotebackup into master

MERGE REQUEST

MR Guidelines

Overview

There was a panic in TestRemoteBackup due to the cancel chan not being initialized. I found that there was inconsistent use of the newJobGeneric function. I updated all references to use newJobGeneric and found that the snapshot code was not initializing the cancel chan leading to the panic.

Example for Visual Changes

Checklist

Review and complete the checklist to ensure that the MR is complete before assigned to an approver.

  • All new methods or updated methods have clear docstrings
  • Testing added or updated for new methods
  • Any new packages are added to Makefile and .gitlab-ci.yml
  • API documentation updated for API updates
  • Module README.md updated for changes to workflow
  • Issue added to Sia-UI repo for new supporting features
  • Changelog File Created

Issues Closed

Closes #4265 (closed)

Edited by Matthew Sevey

Merge request reports