Skip to content

Fix deadlock in case host reports unknown storage obligation

Christopher Schinnerl requested to merge providepayment-deadlock into master

MERGE REQUEST

MR Guidelines

Overview

In ProvidePayment, we acquire a safe contract and then potentially call MarkContractBad on the same contract. MarkContractBad tries to acquire the same contract again which causes a deadlock. To fix this, it now calls managedMarkContractBad which already accepts a safecontract instead of acquiring one itself.

Checklist

Review and complete the checklist to ensure that the MR is complete before assigned to an approver.

  • All new methods or updated methods have clear docstrings
  • Testing added or updated for new methods
  • Any new packages are added to Makefile and .gitlab-ci.yml
  • API documentation updated for API updates
  • Module README.md updated for changes to workflow
  • Issue added to Sia-UI repo for new supporting features
  • Changelog File Created
Edited by Christopher Schinnerl

Merge request reports