Skip to content

Add minAcceptedPriceTableValidity

Peter-Jan Brone requested to merge pt-zero-validity into master

MERGE REQUEST

MR Guidelines

Overview

This MR extends the PT gouging check with a min validity check. This fixes a divide by zero error I encountered on production. Instead of checking for 0 validity, I decided it makes sense to add a minimum lower bound to this field.

Note

We are implementing something similar on the host side to ensure hosts are at least aware the renter won't accept very low validity durations. See #4253

Example for Visual Changes

N/A

Checklist

Review and complete the checklist to ensure that the MR is complete before assigned to an approver.

  • All new methods or updated methods have clear docstrings
  • Testing added or updated for new methods
  • Any new packages are added to Makefile and .gitlab-ci.yml
  • API documentation updated for API updates
  • Module README.md updated for changes to workflow
  • Issue added to Sia-UI repo for new supporting features
  • Changelog File Created

Issues Closed

N/A

Edited by Peter-Jan Brone

Merge request reports