Skip to content

Add the needed locks to `modules/renter/proto`.

Ivaylo Novakov requested to merge ivo/renter_proto_lockcheck into master

MERGE REQUEST

MR Guidelines

Overview

Add modules/renter/proto to the list of modules covered by the lockcheck analysis and make sure all the checks pass.

Note:

I think the code is good but the tests keep failing because of two NFDs - #4166 and #4085. Or maybe the new locks exacerbate those problems. We can either merge now or focus on the NDFs first.

I'm assigning this for review, so I can get feedback on this.

Example for Visual Changes

Checklist

Review and complete the checklist to ensure that the MR is complete before assigned to an approver.

  • All new methods or updated methods have clear docstrings
  • Testing added or updated for new methods
  • Any new packages are added to Makefile and .gitlab-ci.yml
  • API documentation updated for API updates
  • Module README.md updated for changes to workflow
  • Issue added to Sia-UI repo for new supporting features
  • Changelog File Created

Issues Closed

Closes #4143 (closed)

Edited by Ivaylo Novakov

Merge request reports