Skip to content

Stop running `go mod tidy` on lint.

Ivaylo Novakov requested to merge ivo/untidy into master

MERGE REQUEST

MR Guidelines

Overview

Running go mod tidy on lint sounds like a great idea but unfortunately has negative side effects, namely a large number of annoying merge conflicts that wast a lot of time. This MR removes the automatic execution and defers to the programmer to decide when to tidy the modules file. I typically only do that when modifying the modules I use.

We should integrate go mod tidy in our release process, so we can rest assured that we're shipping the latest and greatest.

Example for Visual Changes

Checklist

Review and complete the checklist to ensure that the MR is complete before assigned to an approver.

  • All new methods or updated methods have clear docstrings
  • Testing added or updated for new methods
  • Any new packages are added to Makefile and .gitlab-ci.yml
  • API documentation updated for API updates
  • Module README.md updated for changes to workflow
  • Issue added to Sia-UI repo for new supporting features
  • Changelog File Created

Issues Closed

Merge request reports