Skip to content

Cleanly apply unapplied contract transactions to fix WAL leak

Christopher Schinnerl requested to merge wal-txn-leak into master

MERGE REQUEST

MR Guidelines

Overview

It looks like our Skynet portals leak Wal transactions since their Wal are already multiple gigabytes big. I realised that the commitment method in the safe contract will just set the unappliedTxns to nil without marking them to be applied. This might cause existing unapplied tens to leak and not be applied without a reboot. This MR contains regression tests and a fix.

Checklist

Review and complete the checklist to ensure that the MR is complete before assigned to an approver.

  • All new methods or updated methods have clear docstrings
  • Testing added or updated for new methods
  • Any new packages are added to Makefile and .gitlab-ci.yml
  • API documentation updated for API updates
  • Module README.md updated for changes to workflow
  • Issue added to Sia-UI repo for new supporting features
  • Changelog File Created
Edited by Christopher Schinnerl

Merge request reports