Skip to content

fix deadlock caused by incorrect timer usage

David Vorick requested to merge memleak into master

Overview

Fix a deadlock in DownloadByRoot caused by incorrect usage of timers. This was leading to memory not being returned to the memory manager, which would cause the whole renter to freeze up.

Note: no changelog update needed, DownloadByRoot is not released in a version yet.

Checklist

Review and complete the checklist to ensure that the MR is complete before assigned to an approver.

  • All new methods or updated methods have clear docstrings
  • Testing added or updated for new methods
  • Any new packages are added to Makefile and .gitlab-ci.yml
  • API documentation updated for API updates
  • Module README.md updated for changes to workflow
  • Issue added to Sia-UI repo for new supporting features
  • Changelog File Created

Merge request reports