WIP: Add modules/renter/proto to the lockcheck list.
MERGE REQUEST
Overview
This MR adds modules/renter/proto to the list of packages checked for locking issues. It also resolves the existing locking issues.
Some issues got resolved by making the deps and dir fields static. They look static to me but please pay extra attention to that when reviewing the MR. The rest of the issues required adding locking.
This might affect performance, especially the formation of new contracts with a brand new wallet or the initial ramp up of a portal.
Example for Visual Changes
Checklist
Review and complete the checklist to ensure that the MR is complete before assigned to an approver.
-
All new methods or updated methods have clear docstrings -
Testing added or updated for new methods -
Any new packages are added to Makefile and .gitlab-ci.yml -
API documentation updated for API updates -
Module README.md updated for changes to workflow -
Issue added to Sia-UI repo for new supporting features -
Changelog File Created
Issues Closed
Closes #4143 (closed)
Edited by Ivaylo Novakov