Resolve "Follow-up from "Resolve "Follow-up from "Start using WAL": CreateAndApplyTransaction should panic on error"""

MERGE REQUEST

MR Guidelines

Overview

The following discussions from !4306 (merged) should be addressed:

• @pjbrone started a discussion: (+1 comment)

  Not to be a bummer - but we don't do jokes. Can be removed in a F/U

• @pjbrone started a discussion:

  typo: "In case of an error its critical section"

• @pjbrone started a discussion:

  Why can't this simply be if r == dependencies.ErrDiskFault - if that's not possible perhaps errors.Contains(fmt.Errorf("%v", r), dependencies.ErrDiskFault) is more robust?

  Feel free to resolve if you think this is not an improvement at all.

Example for Visual Changes

Checklist

Review and complete the checklist to ensure that the MR is complete before assigned to an approver.

• [ ] All new methods or updated methods have clear docstrings
• [ ] Testing added or updated for new methods
• [ ] Any new packages are added to Makefile and .gitlab-ci.yml
• [ ] API documentation updated for API updates
• [ ] Module README.md updated for changes to workflow
• [ ] Issue added to Sia-UI repo for new supporting features
• [ ] Changelog File Created

Issues Closed

Closes #4107 (closed)