Peter-Jan Brone requested to merge 3975-add-fundaccountrevenue-tracking-on-the-host into master Apr 02, 2020

MERGE REQUEST

Note to reviewer

For now this is still based on 3863-rpc-fundephemeralaccountrpc - please ignore that in your review and focus solely on the added financial metric. Or direct your comments directly to that MR in that MR. I can't seem to get a decent diff between those branches, even though they are both up to date with master. I blame it on gitlab. I hope to merge 3863 soon though.

Overview

This MR adds the AccountFunding field to both the StorageObligation and the host's FinancialMetrics. Note that this field is only ever added to and thus represents all of the money that moved into ephemeral accounts. The actual spending of the money in the ephemeral accounts will get tracked separately and will get tackled in a follow-up.

Example for Visual Changes

N/A

Checklist

Review and complete the checklist to ensure that the MR is complete before assigned to an approver.

All new methods or updated methods have clear docstrings
Testing added or updated for new methods
~~Any new packages are added to Makefile and .gitlab-ci.yml~~
API documentation updated for API updates
~~Module README.md updated for changes to workflow~~
~~Issue added to Sia-UI repo for new supporting features~~
~~Changelog File Created~~

Issues Closed

Closes #3975 (closed)

Edited Apr 06, 2020 by Peter-Jan Brone

Add 'AccountFunding' to the Host's financial metrics