Skip to content

WIP: Worker RHP

Peter-Jan Brone requested to merge 3866-rpc-client into master

MERGE REQUEST

Overview

This MR implements the new RHP on the worker.

It does a couple of things:

  • it removes the completely redundant fundAccountJob
  • it makes sure the worker has a price table and keeps it updated
  • it makes sure the worker has an ephemeral account and keeps it funded

It leaves out other things:

  • balance tracking
  • account persistence

All of which will be followed up.
I have left numerous TODOs which I feel we should tackle in a follow-up as well.
The goal is to get this merged asap, so we can start implementing the jobs.

TODO: I have not added a siatest yet. I am a bit stuck here, seeing as these are all internals. I don't know how I can properly cover it with a siatest. I can't ask the host for ephemeral account stuff, neither can I ask the renter, I also can't query the renter for worker information that would show me it has an EA or updated PT. Need guidance on this.

TODO: #4119 (closed)

NOTE: marked as WIP because this will get replaced most probably with the rhp3-david branch.

Example for Visual Changes (ie Screenshot, asciinema)

N/A

Checklist

TODO:

  • Testing added or updated for new methods

Review and complete the checklist to ensure that the MR is complete before assigned to an approver.

  • All new methods or updated methods have clear docstrings
  • Any new packages are added to Makefile and .gitlab-ci.yml
  • API documentation updated for API updates
  • Module README.md updated for changes to workflow
  • Issue added to Sia-UI repo for new supporting features
  • Changelog File Created

Issues Closed

Closes #3866 (closed)

Edited by Peter-Jan Brone

Merge request reports