Skip to content

Skyfile download panic

Matthew Sevey requested to merge sevey-fix-skyfile-download-panic into master

MERGE REQUEST

Overview

User @jav_ found a bug where siad would panic for malformed skylinks that created fanout sizes that exceeded the capacity of the basesector. This MR adds a sanity check and returns an error to avoid the panic.

Example for Visual changes (ie Screenshot)

Issues Closed

Closes #3873 (closed)

Checklist

Review and complete the checklist to ensure that the MR is complete before assigned to an approver.

  • All new methods, or updating methods have clear docstrings
  • Testing added or updated for new methods
  • Any new packages are added to Makefile and .gitlab-ci.yml
  • API documentation updated for API updates
  • Module README.md updated for changes to work flow
  • Issue added to Sia-UI repo for new supporting features
  • Changelog updated
Edited by Matthew Sevey

Merge request reports