Skip to content

Host DB Testing

David Vorick requested to merge hdbtest into master

There's not a whole lot happening in this PR. I wrote a few tests to check that inactive hosts were working correctly. Checking that active hosts are working correctly is going to require making fake RPCs... we're just going to have to leave this to the integration testing for this week.

I completely refactored insert, now it's got a lot less side effects and more standard/expected behavior. insert puts stuff into the full set, then determines if it belongs in the active set. threadedActiveInsert gets the host settings and gives up if the host is offline. If the host is online, it grabs the settings and calls insertCompleteHostEntry, which removes any conflicts and then inserts the host.

Each of these functions is independent, and can be called without problems or side effects individually.

The docstrings might not be perfect. I tried to go through and fix them all.

Merge request reports