Skip to content

efficiently remove transactions from miner unsolved block

Christopher Schinnerl requested to merge marcinja:remove-from-block into master

Created by: marcinja

Before:

=== RUN   TestFeeEstimation
--- PASS: TestFeeEstimation (45.80s)
=== RUN   TestTpoolScalability
--- PASS: TestTpoolScalability (54.17s)
=== RUN   TestHeapFees
--- PASS: TestHeapFees (59.54s)

After:

=== RUN   TestFeeEstimation
--- PASS: TestFeeEstimation (47.18s)
=== RUN   TestTpoolScalability
--- PASS: TestTpoolScalability (30.35s)
=== RUN   TestHeapFees
--- PASS: TestHeapFees (32.76s)

Edit: TestBigTpool is probably too big. It fills up the tpool with at least 3 blocks worth of transactions (~6MB+), takes an enormous amount of time (150+ seconds) and is a lot of lines of code. It might be a good idea to define some helper functions inside the test to make it easier to read.

Merge request reports