Skip to content

Faster host upgrades + storage folder operations

David Vorick requested to merge faster-alloc into master

PR is not finished - namely the test suite is broken now b/c it measures whether or not WriteAt gets called, but now we use Truncate instead, so the suite gets upset because it doesn't think we are writing out the file.

First reordered the upgrade process so that people with massive storage arrays can interrupt the growth phase without being forced to write out a full 500TB over NFS.

Second switched from doing 0-writes to doing incremental truncates. Some quick searching informed me that calling 'Truncate' is the correct way to create sparse files, and that writing zeroes is a lot slower. Updated my benchmarks PR as well, which now shows that calling Truncate is pretty fast. I guess I should also write a benchmark for tail-0 writing.

This new PR should provide great speedups for filesystems that support sparse files without impacting the performance or progress-ness of filesystems that don't support sparse files.

Made this PR quickly so that it could get reviewed faster.

Merge request reports