Skip to content

Gateway version handshake

Christopher Schinnerl requested to merge vw-gateway-version-handshake into master

Created by: VoidingWarranties

This PR moves the version handshake network code from Connect and threadedAcceptConn to connectVersionHandshake and acceptConnVersionHandshake, respectively. The primary reason for doing this is to be able to pass the version that is sent in the handshake as an argument to the function. This is useful as build.Version is a const and is difficult to mock.

This PR is a prerequisite for the testing required in #1192 (closed).

Merge request reports